Replace panic! with bare assert! in test git helpers
Assisted-by: GLM-5.1 via pi
diff --git a/src/ci/run.rs b/src/ci/run.rs
index 83314a4..7d2af18 100644
--- a/src/ci/run.rs
+++ b/src/ci/run.rs
@@ -548,7 +548,11 @@ mod tests {
run.transition(RunState::Active).expect("to active");
let times = run.read_times().expect("read times");
- assert_eq!(times.started_at, Some(pre), "should keep pre-set started_at");
+ assert_eq!(
+ times.started_at,
+ Some(pre),
+ "should keep pre-set started_at"
+ );
}
#[test]
@@ -843,7 +847,9 @@ mod tests {
let err = run
.execute(pipeline, HashMap::new())
.expect_err("expected failure");
- let Error::JobFailed { job, source } = err else { unreachable!() };
+ let Error::JobFailed { job, source } = err else {
+ unreachable!()
+ };
assert_eq!(job, "grab");
let msg = source.to_string();
assert!(
@@ -868,7 +874,9 @@ mod tests {
let err = run
.execute(pipeline, HashMap::new())
.expect_err("expected failure");
- let Error::JobFailed { source, .. } = err else { unreachable!() };
+ let Error::JobFailed { source, .. } = err else {
+ unreachable!()
+ };
let msg = source.to_string();
assert!(
msg.contains("not in transitive inputs") && msg.contains("peer"),
@@ -890,7 +898,9 @@ mod tests {
let err = run
.execute(pipeline, HashMap::new())
.expect_err("expected failure");
- let Error::JobFailed { source, .. } = err else { unreachable!() };
+ let Error::JobFailed { source, .. } = err else {
+ unreachable!()
+ };
let msg = source.to_string();
assert!(
msg.contains("cannot read its own outputs"),
diff --git a/src/quire.rs b/src/quire.rs
index 2172046..f52f65a 100644
--- a/src/quire.rs
+++ b/src/quire.rs
@@ -371,13 +371,7 @@ mod tests {
.env("GIT_CONFIG_SYSTEM", "/dev/null")
.output()
.expect("git command");
- if !output.status.success() {
- panic!(
- "git {:?} failed:\n{}",
- args,
- String::from_utf8_lossy(&output.stderr)
- );
- }
+ assert!(output.status.success());
output
};
@@ -418,13 +412,7 @@ mod tests {
.env("GIT_CONFIG_SYSTEM", "/dev/null")
.output()
.expect("git command");
- if !output.status.success() {
- panic!(
- "git {:?} failed:\n{}",
- args,
- String::from_utf8_lossy(&output.stderr)
- );
- }
+ assert!(output.status.success());
output
};
@@ -456,13 +444,7 @@ mod tests {
.env("GIT_CONFIG_SYSTEM", "/dev/null")
.output()
.expect("git command");
- if !output.status.success() {
- panic!(
- "git {:?} failed:\n{}",
- args,
- String::from_utf8_lossy(&output.stderr)
- );
- }
+ assert!(output.status.success());
output
};
@@ -799,13 +781,7 @@ mod tests {
.env("GIT_CONFIG_SYSTEM", "/dev/null")
.output()
.expect("git command");
- if !output.status.success() {
- panic!(
- "git {:?} failed:\n{}",
- args,
- String::from_utf8_lossy(&output.stderr)
- );
- }
+ assert!(output.status.success());
}
/// Helper: create a bare repo at `bare` with `main` and one commit.